ipc4: remove needless interrupt disabling#10125
Draft
lyakh wants to merge 1 commit intothesofproject:mainfrom
Draft
ipc4: remove needless interrupt disabling#10125lyakh wants to merge 1 commit intothesofproject:mainfrom
lyakh wants to merge 1 commit intothesofproject:mainfrom
Conversation
ipc4_get_drv() is called from ipc4_get_comp_drv() in IPC context, and that can run on different cores, so just disabling local interrupts doesn't provide proper protection. On the other hand IPCs are serialised, and the global driver list can only be modified from IPC context, so there is no need to protect it here. Remove the interrupt lock. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ipc4_get_drv() is called from ipc4_get_comp_drv() in IPC context, and that can run on different cores, so just disabling local interrupts doesn't provide proper protection. On the other hand IPCs are serialised, and the global driver list can only be modified from IPC context, so there is no need to protect it here. Remove the interrupt lock.